Compare commits

...

2 commits
v1.7.0 ... main

Author SHA1 Message Date
ca41ea4c50 Fixed no row-error 2025-09-29 09:34:14 +02:00
ad601219ec Upgraded to pgx 2025-09-23 21:47:39 +02:00
3 changed files with 67 additions and 51 deletions

View file

@ -1,8 +1,11 @@
package dbschema package dbschema
import ( import (
// External
"github.com/jackc/pgx/v5/pgxpool"
// Standard // Standard
"database/sql" "context"
"fmt" "fmt"
) )
@ -13,10 +16,10 @@ func newDatabase(host string, port int, dbName, user, pass string) (dbase Databa
dbase.Username = user dbase.Username = user
dbase.Password = pass dbase.Password = pass
dbase.db, err = sql.Open("postgres", dbase.sqlConnString()) dbase.db, err = pgxpool.New(context.Background(), dbase.sqlConnString())
return return
}// }}} }// }}}
func databaseFromInstance(db *sql.DB) (dbase Database, err error) { func databaseFromInstance(db *pgxpool.Pool) (dbase Database, err error) {
dbase.db = db dbase.db = db
return return
} }

View file

@ -21,10 +21,7 @@ package dbschema
import ( import (
// External // External
_ "github.com/lib/pq" "github.com/jackc/pgx/v5/pgxpool"
// Standard
"database/sql"
) )
// An upgrader verifies the schema for one or more databases and upgrades them if possible. // An upgrader verifies the schema for one or more databases and upgrades them if possible.
@ -42,7 +39,7 @@ type Database struct {
Username string Username string
Password string Password string
db *sql.DB db *pgxpool.Pool
upgrader *Upgrader upgrader *Upgrader
} }

View file

@ -2,10 +2,12 @@ package dbschema
import ( import (
// External // External
"github.com/lib/pq" "github.com/jackc/pgx/v5"
"github.com/jackc/pgx/v5/pgconn"
"github.com/jackc/pgx/v5/pgxpool"
// Standard // Standard
"database/sql" "context"
"fmt" "fmt"
) )
@ -49,17 +51,18 @@ func (upgrader *Upgrader) Version(dbName string) (version int, err error) {// {{
func (dbase Database) createSchemaTable() (err error) { // {{{ func (dbase Database) createSchemaTable() (err error) { // {{{
dbase.upgrader.logCallback("create", fmt.Sprintf("%s, %s.schema", dbase.DbName, dbase.upgrader.schema)) dbase.upgrader.logCallback("create", fmt.Sprintf("%s, %s.schema", dbase.DbName, dbase.upgrader.schema))
_, err = dbase.db.Exec(`CREATE SCHEMA "`+dbase.upgrader.schema+`"`) _, err = dbase.db.Exec(context.Background(), `CREATE SCHEMA "` + dbase.upgrader.schema + `"`)
// Error code 42P06 "duplicate_schema" is an OK error, // Error code 42P06 "duplicate_schema" is an OK error,
// table can still be missing and created. // table can still be missing and created.
pqErr, _ := err.(*pq.Error) pqErr, _ := err.(*pgconn.PgError)
if pqErr != nil && pqErr.Code != "42P06" { if pqErr != nil && pqErr.Code != "42P06" {
return return
} }
_, err = dbase.db.Exec(` _, err = dbase.db.Exec(
CREATE TABLE "`+dbase.upgrader.schema+`"."schema" ( context.Background(),
`CREATE TABLE "` + dbase.upgrader.schema + `"."schema" (
version int4 NOT NULL, version int4 NOT NULL,
updated timestamp NOT NULL DEFAULT NOW(), updated timestamp NOT NULL DEFAULT NOW(),
@ -69,13 +72,14 @@ func (dbase Database) createSchemaTable() (err error) {// {{{
return return
} // }}} } // }}}
func (dbase Database) appendSchemaVersion(version int) (err error) { // {{{ func (dbase Database) appendSchemaVersion(version int) (err error) { // {{{
_, err = dbase.db.Exec(`INSERT INTO `+dbase.upgrader.schema+`.schema(version) VALUES($1)`, version) _, err = dbase.db.Exec(context.Background(), `INSERT INTO `+dbase.upgrader.schema+`.schema(version) VALUES($1)`, version)
return return
} // }}} } // }}}
func (dbase Database) verifySchemaTable() (err error) { // {{{ func (dbase Database) verifySchemaTable() (err error) { // {{{
var rows *sql.Rows var rows pgx.Rows
if rows, err = dbase.db.Query( if rows, err = dbase.db.Query(
context.Background(),
`SELECT EXISTS ( `SELECT EXISTS (
SELECT FROM pg_catalog.pg_class c SELECT FROM pg_catalog.pg_class c
JOIN pg_catalog.pg_namespace n ON n.oid = c.relnamespace JOIN pg_catalog.pg_namespace n ON n.oid = c.relnamespace
@ -100,11 +104,11 @@ func (dbase Database) verifySchemaTable() (err error) {// {{{
} // }}} } // }}}
func (dbase Database) verifySchemaEntry() (err error) { // {{{ func (dbase Database) verifySchemaEntry() (err error) { // {{{
var version int var version int
var row *sql.Row var row pgx.Row
row = dbase.db.QueryRow(`SELECT version FROM `+dbase.upgrader.schema+`.schema LIMIT 1`) row = dbase.db.QueryRow(context.Background(), `SELECT version FROM `+dbase.upgrader.schema+`.schema LIMIT 1`)
err = row.Scan(&version) err = row.Scan(&version)
if err == sql.ErrNoRows { if err == pgx.ErrNoRows {
dbase.upgrader.logCallback("initiate version", dbase.DbName) dbase.upgrader.logCallback("initiate version", dbase.DbName)
err = dbase.appendSchemaVersion(0) err = dbase.appendSchemaVersion(0)
} }
@ -112,8 +116,9 @@ func (dbase Database) verifySchemaEntry() (err error) {// {{{
return return
} // }}} } // }}}
func (dbase Database) Version() (version int, err error) { // {{{ func (dbase Database) Version() (version int, err error) { // {{{
var rows *sql.Rows var rows pgx.Rows
rows, err = dbase.db.Query( rows, err = dbase.db.Query(
context.Background(),
`SELECT version FROM ` + dbase.upgrader.schema + `.schema ORDER BY version DESC LIMIT 1`, `SELECT version FROM ` + dbase.upgrader.schema + `.schema ORDER BY version DESC LIMIT 1`,
) )
if err != nil { if err != nil {
@ -145,8 +150,19 @@ func (upgrader Upgrader) AddDatabase(host string, port int, dbName, user, pass s
err = db.verifySchemaEntry() err = db.verifySchemaEntry()
return return
} // }}} } // }}}
func (upgrader Upgrader) AddDatabaseInstance(sqlDB *sql.DB) (db Database, err error) {// {{{ func (upgrader Upgrader) AddDatabaseInstance(sqlDB *pgxpool.Pool, dbName string) (db Database, err error) { // {{{
return databaseFromInstance(sqlDB) db, err = databaseFromInstance(sqlDB)
db.upgrader = &upgrader
upgrader.databases[dbName] = db
if err = db.verifySchemaTable(); err != nil {
return
}
err = db.verifySchemaEntry()
return
} // }}} } // }}}
// Run executes the actual schema updates until there are no more available. // Run executes the actual schema updates until there are no more available.
@ -168,7 +184,7 @@ func (upgrader Upgrader) Run() (err error) {// {{{
} }
upgrader.logCallback("exec", fmt.Sprintf("%s.%s: %d", dbName, upgrader.schema, version)) upgrader.logCallback("exec", fmt.Sprintf("%s.%s: %d", dbName, upgrader.schema, version))
if _, err = dbase.db.Exec(string(sql)); err != nil { if _, err = dbase.db.Exec(context.Background(), string(sql)); err != nil {
return return
} }
if err = dbase.appendSchemaVersion(version); err != nil { if err = dbase.appendSchemaVersion(version); err != nil {